CB/ui: Update link color in homepage about box #125
Beowulf
Gusted
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "mverkleij/forgejo:update-link-color-homepage"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The files section contains a screenshot that shows the proposed change in Firefox
Alternatively, we could do away with the underline. I initially added it as I thought the contrast of the link color to the rest of the text was not sufficient to properly make out that it is a link.
The contrast is this low as the lower
--color-primary-light-xvariables did not pass the WCAG AA test for contrast against the background41267b8a90to01ff1f718eI have changed the color as a consequence of the Matrix discussion. See enclosed the current situation
For this block it should work well on both dark and light themes. But no need to keep the partially commented out code.
This PR can be considered a followup to #120.
I'll drop request because my reviews have no authority in this repo. I'm just in Forgejo's CODEOWNERS file.
01ff1f718eto5340d56534I'm not exactly sure about the exact color, it feels the contrast is too low. Something in the ballpark of
#79bbf0might be an option?Regarding the underline, it's an interesting idea but I'd prefer the consistency and that would need to be applied for all links in Codeberg then (which I would say is a very nice option we should offer, although more of a feature in Forgejo itself).
5340d56534toebc3618b72Applying @Gusted's suggested colour looks like the pictures attached. Looks good to me, and I agree with the contrast being better.*
ebc3618b72to503a6c1067Thanks!