chore(Dockerfile.rootless): remove legacy config file support #11098
Labels
No labels
arch
riscv64
backport/v1.19
backport/v1.20
backport/v1.21/forgejo
backport/v10.0/forgejo
backport/v11.0/forgejo
backport/v12.0/forgejo
backport/v13.0/forgejo
backport/v14.0/forgejo
backport/v7.0/forgejo
backport/v8.0/forgejo
backport/v9.0/forgejo
breaking
bug
bug
confirmed
bug
duplicate
bug
needs-more-info
bug
new-report
bug
reported-upstream
code/actions
code/api
code/auth
code/auth/faidp
code/auth/farp
code/email
code/federation
code/git
code/migrations
code/packages
code/wiki
database
MySQL
database
PostgreSQL
database
SQLite
dependency-upgrade
dependency
certmagic
dependency
chart.js
dependency
Chi
dependency
Chroma
dependency
citation.js
dependency
codespell
dependency
css-loader
dependency
devcontainers
dependency
dropzone
dependency
editorconfig-checker
dependency
elasticsearch
dependency
enmime
dependency
F3
dependency
ForgeFed
dependency
garage
dependency
Git
dependency
git-backporting
dependency
Gitea
dependency
gitignore
dependency
go-ap
dependency
go-enry
dependency
go-gitlab
dependency
Go-org
dependency
go-rpmutils
dependency
go-sql-driver mysql
dependency
go-swagger
dependency
go-version
dependency
go-webauthn
dependency
gocron
dependency
Golang
dependency
goldmark
dependency
goquery
dependency
Goth
dependency
grpc-go
dependency
happy-dom
dependency
Helm
dependency
image-spec
dependency
jsonschema
dependency
KaTeX
dependency
lint
dependency
MariaDB
dependency
Mermaid
dependency
minio-go
dependency
misspell
dependency
Monaco
dependency
PDFobject
dependency
playwright
dependency
postcss
dependency
postcss-plugins
dependency
pprof
dependency
prometheus client_golang
dependency
protobuf
dependency
relative-time-element
dependency
renovate
dependency
reply
dependency
ssh
dependency
swagger-ui
dependency
tailwind
dependency
temporal-polyfill
dependency
terminal-to-html
dependency
tests-only
dependency
text-expander-element
dependency
urfave
dependency
vfsgen
dependency
vite
dependency
Woodpecker CI
dependency
x tools
dependency
XORM
Discussion
duplicate
enhancement/feature
forgejo/accessibility
forgejo/branding
forgejo/ci
forgejo/commit-graph
forgejo/documentation
forgejo/furnace cleanup
forgejo/i18n
forgejo/interop
forgejo/moderation
forgejo/privacy
forgejo/release
forgejo/scaling
forgejo/security
forgejo/ui
Gain
High
Gain
Nice to have
Gain
Undefined
Gain
Very High
good first issue
i18n/backport-stable
impact
large
impact
medium
impact
small
impact
unknown
Incompatible license
issue
closed
issue
do-not-exist-yet
issue
open
manual test
Manually tested during feature freeze
OS
FreeBSD
OS
Linux
OS
macOS
OS
Windows
problem
QA
regression
release blocker
Release Cycle
Feature Freeze
release-blocker
v7.0
release-blocker
v7.0.1
release-blocker
v7.0.2
release-blocker
v7.0.3
release-blocker
v7.0.4
release-blocker
v8.0.0
release-blocker/v9.0.0
run-all-playwright-tests
run-end-to-end-tests
test
manual
test
needed
test
needs-help
test
not-needed
test
present
untested
User research - time-tracker
valuable code
worth a release-note
User research - Accessibility
User research - Blocked
User research - Community
User research - Config (instance)
User research - Errors
User research - Filters
User research - Future backlog
User research - Git workflow
User research - Labels
User research - Moderation
User research - Needs input
User research - Notifications/Dashboard
User research - Rendering
User research - Repo creation
User research - Repo units
User research - Security
User research - Settings (in-app)
No milestone
No project
No assignees
7 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo/forgejo!11098
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "jaylinski/forgejo:rootless-image-remove-legacy-ini"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Docs PR: forgejo/docs#1740
This legacy support was added in version 8. We now have version 14, so this deprecated feature can be confidently removed.
See
dad16cd589for a detailed explanation.Checklist
The contributor guide contains information that will be helpful to first time contributors. There also are a few conditions for merging Pull Requests in Forgejo repositories. You are also welcome to join the Forgejo development chatroom.
Tests
*_test.gofor unit tests.tests/integrationdirectory if it involves interactions with a live Forgejo server.web_src/js/*.test.jsif it can be unit tested.tests/e2e/*.test.e2e.jsif it requires interactions with a live Forgejo server (see also the developer guide for JavaScript testing).Documentation
Release notes
The decision if the pull request will be shown in the release notes is up to the mergers / release team.
The content of the
release-notes/<pull request number>.mdfile will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead.Release notes
/etc/gitea/app.inito/var/lib/gitea/app.ini. Backward compatibility logic and startup warnings were added to container setup and entrypoint scripts. Now they are removed. This change only affects those using container deployments with rootless images. If you have the config file stored in a volume bound to container's /etc/gitea, move it to the new location or override the environment variableGITEA_APP_INI. An unused volume/etc/giteacan be safely removed from the container after moving the config or if the deployment never used versions prior to v8.0.0.Pull request to change documentation: forgejo/docs#1740
Where does that come from?
The following is a preview of the release notes for this pull request, as they will appear in the upcoming release. They are derived from the content of the `release-notes/11098.md` file, if it exists, or the title of the pull request. They were also added at the bottom of the description of this pull request for easier reference.This message and the release notes originate from a call to the release-notes-assistant.
Release notes
I don't use docker, so not sure how big of a problem this still is (as in how many users) and if the warning has been seen by many. @viceice maybe you have some insights into this?
@Gusted wrote in #11098 (comment):
I only use it in the helm chart which is always override the app ini path explicit. so it was ok to maintain the workaround for a while and can now be removed.
https://code.forgejo.org/forgejo-helm/forgejo-helm/search/branch/main?path=&q=GITEA_APP_INI&mode=exact
Is this worth of a dedicated release note entry that explains what support is being removed and the migration path? It's already clearly given for the past few releases but will now be removed along with the support. @forgejo/Releases.
@Gusted wrote in #11098 (comment):
The addition in Forgejo 8 was long enough for people to get used to ignoring the warning, so a little explanation linking to a detailed one is good to add.
@0ko wrote in #11098 (comment):
I feel called out...
🥴
And I remember why I haven't changed it, because I did run into it again:
After moving the config file to the new place and deleting the file in the old place, forgejo just crash-looped. Last time I just reverted, because
docker logsjust showed everything is fine, but this time I took a look and found in the log file:I have no idea, how this happened due to moving the config file? 🤔
@Beowulf wrote in #11098 (comment):
The config file is referenced in the
authorized_keysfile. If it changes, it doesn't match Forgejo's expected file contents.@mfenniak wrote in #11098 (comment):
Ah, you're right, I don't even use the
authorized_keysfile in this instance, this was another reason, why I haven't thought about this.But I think this is another reason to mention it clearly in the release notes.
Hi! Thanks for the review. Is there anything else I should do to get this merged?
Hi! There are some weird CI failures on your branch.
050d9c291e570580356b@0ko wrote in #11098 (comment):
I rebased the branch, please run the CI pipelines again.
I added a dedicated release note per #11098 (comment) / #11098 (comment).
I think this is mergeable but need someone to approve the release note.
@ -0,0 +1 @@In Forgejo v8.0.0, the default location for the config file was changed from `/etc/gitea/app.ini` to `/var/lib/gitea/app.ini`. Backward compatibility logic and startup warnings were added to container setup and entrypoint scripts. Now they are removed. This change only affects those using container deployments with rootless images. If you have the config file stored in a volume bound to container's /etc/gitea, move it to the new location or override the environment variable `GITEA_APP_INI`. An unused `/etc/gitea` can be safely from container volumes after moving the config or if the deployment never used versions prior to v8.0.0.'An unused
/etc/giteacan be safely from container'Word missing after 'safely'?
Where does that come from?
The following is a preview of the release notes for this pull request, as they will appear in the upcoming release. They are derived from the content of the `release-notes/11098.md` file, if it exists, or the title of the pull request. They were also added at the bottom of the description of this pull request for easier reference.This message and the release notes originate from a call to the release-notes-assistant.
Release notes
/etc/gitea/app.inito/var/lib/gitea/app.ini. Backward compatibility logic and startup warnings were added to container setup and entrypoint scripts. Now they are removed. This change only affects those using container deployments with rootless images. If you have the config file stored in a volume bound to container's /etc/gitea, move it to the new location or override the environment variableGITEA_APP_INI. An unused volume/etc/giteacan be safely removed from the container after moving the config or if the deployment never used versions prior to v8.0.0.