CB/ui: Add consent message and cleaner warning #108
Gusted
mahlzahn
fogti
fnetX
ashimokawa
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "n0toose/ui-registration-consent"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Template applied to a Forgejo tree.
Can't we just remove this warning? I doubt that real spammers will be stopped by that. And for proper users that has no impact.
Edit: The consent message looks good!
I'd agree somewhat, but I tried to make it more low-key/tasteful for starters. I also had the implicit goal of getting people to read the ToU. I presume this was added by @ashimokawa
@ -50,0 +42,4 @@</div><div class="ui message" style="text-align: start; color:var(--color-warning-text);" tabindex=0 aria-labelledby="warning"><p id="warning">Using Codeberg for SEO spam, spreading warez and IPTV links, or uploading large amounts of copyrighted, non-free material <b>will</b> result in an immediate ban with <b>no prior warning</b>.</p>why is this
plabeled withid="warning"? For styling, I would've expectedclass="warning"I did this as I followed the
aria-labelledbyapproach preceding my change.@n0toose
Sounds if uploading small amounts of copyrighted material is okay :D
I had private repositories in mind - for people that own the rights to the content they upload. Should I still fix this?
Then we have three cases to consider:
The registration page is not an authoritative source to outline our policies, the Terms of Use page is. Just because we mention we'd nuke remove types of accounts on sight, doesn't mean that we are violating any promise by e.g. removing sexist content immediately. If we start getting lots of sexists, it might make sense to add it later.
We should not mention all three cases there. I focused on mentioning common abuse vectors that will 100% get you banned. We should not scare people that might have plans for less clear-cut cases (e.g. proprietary blobs for Linux on Mobile development or lecture notes + actual open-source work) away.
Phew, well, +1 for the links, but my annoying space-using uppercase easy to see keywords had its reason.
There were mutiple chinese accounts registering per day, using codeberg as a storage to iptv links (in some repos called tvbox mostly). I wanted to explicitly make them understand that they are not welcome here, as to me it seems they are in fact not aware of that fact.
@ashimokawa Do you think your warning had any impact? Did you measure it?
I agree it looks far from professional and I would like to have it removed or changed to look as if we're a serious place.
@fnetX
It seems to me that there a lot less new number@qq accounts creating tvbox repos.
Also in the past some complained after removal.
Making clear that we do not want it is good imo.
Also I don't think it looks THAT bad.
Okay, I didn't know that there was a measurable impact - but I tried to account for the possibility that there's background context I was not aware of.
I disagree, it looks as if we, the faceless administrators-deities, are screaming to everyone attempting to make an account - it may have an effect towards the primary audience of the warning (which is very good!), but it has an unintended effect towards the primary audience of Codeberg and its community (which is room for improvement). That's why I'm trying to improve it.
Do you think that we should try and see whether my adjustments will have an impact on the reduction?
100d44b5dbto8efcd326fd8efcd326fdto88cc15422clooks good to me now
@n0toose wrote in #108 (comment):
Just to make sure this was considered, is this message good enough if people register via OAuth2?
@Gusted This should be added to the Sign in page as well then.
@n0toose
Would you do it and then we merge? I do not think we need the extra warning there though.
88cc15422cto6c8bdb6678@ashimokawa i pushed something - but be careful, I didn't manage to test the sign-in page locally yet.
I'm having some i18n-related difficulties with reproduction, so I'd appreciate some assistance here if possible.
What are "i18n-related difficulties with reproduction"?
Sorry - Andreas asked me in private and I answered that to him, but TL;DR no matter what I do, my local Forgejo build of Codeberg's soft-fork seems to think that no translations exist under any circumstances.
The previous screenshot was a result of a manual copy-paste of a template onto the actual Forgejo tree.
Codeberg-specific patches have never been translated. Why do you try to deal with translations in the first place?
If possible, I think it would be nice to have a translation for that, especially because it sets user expectations.
OK, I was missing a
make clean.In the second screenshot, one can see the same box twice when clicking on the "Sign in with..." menu. I'm not sure if that's a problem.
I think you might be able to hide the second one using CSS, and CSS classes. It would however require that you give them different
id='s anyways (otherwise it's invalid HTML).If this is not a problem, I propose we proceed as-is for now.
@ashimokawa Please note that you merged this into codeberg-11, while we are deploying codeberg-12.