Added alt="" to some <img> #103
Gusted
caesar
crystal
lejun
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch ":codeberg-9"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi!
Added a bunch of
alt=""to various parts.tryingfinally succeed to sign my commit using SSH. Consider this a big mess, hopefully useful ;alt=""are left empty, feel free to fill them ;<img>without<alt>.Sorry/thanks!
Default PR text
## ChecklistThe contributor guide contains information that will be helpful to first time contributors. There also are a few conditions for merging Pull Requests in Forgejo repositories. You are also welcome to join the Forgejo development chatroom.
Tests
*_test.gofor unit tests.tests/integrationdirectory if it involves interactions with a live Forgejo server.web_src/js/*.test.jsif it can be unit tested.tests/e2e/*.test.e2e.jsif it requires interactions with a live Forgejo server (see also the developer guide for JavaScript testing).Documentation
Release notes
release-notes/<pull request number>.mdto be be used for the release notes instead of the title.alt=""to some<img>1e2b22202balt=""0e99708598alt=""bfdcf11320alt=""e108e16d8calt=""7758eb2dcfalt=""d7fb112cbcalt=""c9d105e88balt=""to Webhooks f5fea85a05Hi @AntoninDelFabbro thanks for your contribution.
alt=""tags. What is the reason for this?-- https://www.w3.org/TR/html401/struct/objects.html#h-13.8
An alt is required, but I left them empty when:
<img src="tg-icon.png" alt="Telegram">Telegram.@AntoninDelFabbro Thank you! Please split your contribution:
Also note that we follow the more recent HTML5 standard: https://html.spec.whatwg.org/multipage/images.html#alt
The information you linked is still correct in this case, but the HTML5 guide has some improved guidelines and examples in my opinion.
@ -35,3 +35,3 @@}return template.HTML(`<img loading="lazy" class="` + class + `" src="` + src + `" title="` + html.EscapeString(name) + `" width="` + sizeStr + `" height="` + sizeStr + `"/>`)return template.HTML(`<img loading="lazy" alt="" class="` + class + `" src="` + src + `" title="` + html.EscapeString(name) + `" width="` + sizeStr + `" height="` + sizeStr + `"/>`)Should be merged upstream
Hi there, reviewed the file changes and looks like only the home.tmpl issues are Codeberg specific. Otherwise everything may be pushed upstream to Forgejo itself.
To give a bit more context:
By the way (just want to point it out so that we can all gain in common practices, not being a jerk or anything), seems it was @fnetX who removed the alt in the home.tmpl file.
@ -113,3 +113,3 @@<p>Here are some links to the most important topics. You can find the full list of pages at the sidebar.</p><p><a href="` + FullURL + `wiki/Configuration" rel="nofollow">Configuration</a><a href="` + FullURL + `wiki/raw/images/icon-bug.png" rel="nofollow"><img src="` + FullURL + `wiki/raw/images/icon-bug.png" title="icon-bug.png" alt="images/icon-bug.png"/></a></p><a href="` + FullURL + `wiki/raw/images/icon-bug.png" rel="nofollow"><img src="` + FullURL + `wiki/raw/images/icon-bug.png" title="icon-bug.png" alt=""/></a></p>Should be merged upstream
@ -2,3 +2,3 @@<div class="grid" aria-label="{{ctx.Locale.Tr "aria.footer.links"}}"><div class="branding not-mobile" aria-hidden="true"><img src="https://design.codeberg.org/logo-kit/icon_inverted.svg"><img src="https://design.codeberg.org/logo-kit/icon_inverted.svg" alt="{{ctx.Locale.Tr "logo"}}">Should be merged upstream
@ -8,3 +8,3 @@<!-- the logo --><a class="item" id="navbar-logo" href="{{AppSubUrl}}/" aria-label="{{if .IsSigned}}{{ctx.Locale.Tr "dashboard"}}{{else}}{{ctx.Locale.Tr "home"}}{{end}}"><img width="30" height="30" src="https://design.codeberg.org/logo-kit/icon_inverted.svg" aria-hidden="true"><img width="30" height="30" src="https://design.codeberg.org/logo-kit/icon_inverted.svg" alt="{{ctx.Locale.Tr "logo"}}" aria-hidden="true">Should be merged upstream
@ -151,3 +151,3 @@<section id="home-section-support"><h3>Your support helps us grow!<img src="{{AssetUrlPrefix}}/img/svg/codeberg-icon-hearts.svg" role="img" aria-label="Hearts" aria-hidden="true"></h3><h3>Your support helps us grow!<img src="{{AssetUrlPrefix}}/img/svg/codeberg-icon-hearts.svg" role="img" alt="Hearts" aria-label="Hearts" aria-hidden="true"></h3>Seems Codeberg specific
@ -364,3 +364,3 @@</div></div><img class="tw-hidden" src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" width="256" height="256"><img class="tw-hidden" src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" alt="{{ctx.Locale.Tr "loading"}}" width="256" height="256">Should be merged upstream
@ -73,2 +73,2 @@<span class="before-container"><img class="image-before"></span><span class="after-container"><img class="image-after"></span><span class="before-container"><img class="image-before" alt="{{ctx.Locale.Tr "repo.diff.file_before"}}"></span><span class="after-container"><img class="image-after" alt="{{ctx.Locale.Tr "repo.diff.file_after"}}"></span>Should be merged upstream
@ -613,3 +613,3 @@<div class="timeline-item event" id="{{.HashTag}}"><a class="timeline-avatar"{{if gt .Poster.ID 0}} href="{{.Poster.HomeLink}}"{{end}}><img src="{{.Poster.AvatarLink $.Context}}" width="40" height="40"><img src="{{.Poster.AvatarLink $.Context}}" alt="" width="40" height="40">Should be merged upstream
@ -10,3 +10,3 @@<div id="repo_migrating" class="sixteen wide center aligned centered column" data-migrating-task-id="{{.MigrateTask.ID}}"><div><img src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" width="256" height="256"><img src="{{AssetUrlPrefix}}/img/forgejo-loading.svg" alt="{{ctx.Locale.Tr "loading"}}" width="256" height="256">Should be merged upstream
@ -22,3 +22,3 @@<div class="view-raw">{{if .IsImageFile}}<img src="{{$.RawFileLink}}"><img src="{{$.RawFileLink}}" alt="">Should be merged upstream
@ -27,2 +26,3 @@<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/wechatwork.png" alt="">{{else if eq .HookType "packagist"}}<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/packagist.png"><img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/packagist.png" alt="">Should be merged upstream
@ -2,3 +2,3 @@<div class="inline field tw-text-center"><input type="hidden" name="img-captcha-id" value="{{.Captcha}}"><img style="transform: scaleX(-1)" onclick="this.src=`{{AppSubUrl}}/captcha/{{.Captcha}}.png?reload=${Date.now()}`" class="captcha-img" src="{{AppSubUrl}}/captcha/{{.Captcha}}.png"><img style="transform: scaleX(-1)" onclick="this.src=`{{AppSubUrl}}/captcha/{{.Captcha}}.png?reload=${Date.now()}`" class="captcha-img" src="{{AppSubUrl}}/captcha/{{.Captcha}}.png" alt="{{ctx.Locale.Tr "captcha"}}">Should be merged upstream
@ -89,3 +89,3 @@{{$commitLink := printf "%s/commit/%s" $repoLink .Sha1}}<div class="flex-text-block"><img class="ui avatar" src="{{$push.AvatarLink $.Context .AuthorEmail}}" title="{{.AuthorName}}" width="16" height="16"><img class="ui avatar" src="{{$push.AvatarLink $.Context .AuthorEmail}}" alt="" title="{{.AuthorName}}" width="16" height="16">Should be merged upstream
alt's, moved to Forgejo source ede964bd56Done!
& forgejo/forgejo#6506
alt's to<img>#6506