chore: remove webkit and mobile safari from playwright #10103

Merged

Gusted merged 1 commit from gusted/forgejo-rm-webkit-safari into forgejo 2025-11-13 17:23:11 +01:00 AGit

Conversation 0 Commits 1 Files changed 22 +53 -127

Gusted commented 2025-11-13 16:19:15 +01:00

Owner

Copy link

Webkit and Mobile safari are comically unreliable, will fail for unexplainable reasons and are very hard to run locally in comparison with the other supported platforms. I do not remember the last time where these two platforms were able to catch a regression where the other platforms did not.

I would like to stress, for the historical record, that many hours has been devoted into adjusting the tests and following best practices to make these two platforms more stable but despite those, IMO wasted, efforts these two platforms are causing many hours of wasted CPU time simply because they are flaky and make (new) contributors nervous if their change contains a regression or not.

To my knowledge, the tests are not broken for these two platforms. If you go to the issue tracker you will not find issues by users that use these two platforms and report that Forgejo is broken. It does not reflect reality.

This is the sunk cost fallacy, bite the bullet and agree that these platforms will not contribute positively to Forgejo's excellent test suite.

Webkit and Mobile safari are comically unreliable, will fail for unexplainable reasons and are very hard to run locally in comparison with the other supported platforms. I do not remember the last time where these two platforms were able to catch a regression where the other platforms did not. I would like to stress, for the historical record, that many hours has been devoted into adjusting the tests and following best practices to make these two platforms more stable but despite those, IMO wasted, efforts these two platforms are causing many hours of wasted CPU time simply because they are flaky and make (new) contributors nervous if their change contains a regression or not. To my knowledge, the tests are not broken for these two platforms. If you go to the issue tracker you will not find issues by users that use these two platforms and report that Forgejo is broken. It does not reflect reality. This is the sunk cost fallacy, bite the bullet and agree that these platforms will not contribute positively to Forgejo's excellent test suite.

❤️ 1 🚀 6

Gusted added 1 commit 2025-11-13 16:19:15 +01:00

chore: remove webkit and mobile safari from playwright ... 0e8b2b653a

They are comically unreliable, will fail for unexplainable reasons and
are very hard to run locally in comparisions with the other supported
platforms. I do not remember the last time where these two platforms
were able to catch a regression where the other platforms did not.

I would like to stress, for the historical record, that many hours has
been devoted into adjusting the tests and following best practices to
make these two platforms but despite those, IMO wasted, efforts these
two platforms are causing many hours of wasted CPU time simply because
they are flaky and make (new) contributors nervous if their change
contains a regression or not.

To my knowledge, the tests are not broken for these two platforms. If
you go to the issue tracker you will not find many issues by users that
use these two platforms and report that Forgejo is broken. It does not
reflect reality.

This is the sunk cost fallacy, bite the bullet and agree that these
platforms will not contribute postively to Forgejo's excellent test
suite.

Gusted 2025-11-13 16:19:16 +01:00

• added the
  test
  not-needed
  label
• requested review from fnetX

viceice approved these changes 2025-11-13 16:23:13 +01:00

viceice left a comment

Owner

Copy link

❤️

❤️

mfenniak approved these changes 2025-11-13 17:10:47 +01:00

0ko approved these changes 2025-11-13 17:11:13 +01:00

Gusted referenced this pull request from a commit 2025-11-13 17:23:10 +01:00

chore: remove webkit and mobile safari from playwright (#10103)

Gusted merged commit 0737196842 into forgejo 2025-11-13 17:23:11 +01:00

forgejo-release-notes-assistant added this to the Forgejo v14.0.0 milestone 2025-11-13 17:26:24 +01:00

fnetX approved these changes 2025-11-14 00:00:27 +01:00

fnetX left a comment

Owner

Copy link

I agree. Forgejo's test suite is getting pretty good. The time that went into debugging the safari tests can now be spent in other areas to make it even better.

I agree. Forgejo's test suite is getting pretty good. The time that went into debugging the safari tests can now be spent in other areas to make it even better.

alberic89 referenced this pull request from a commit 2026-02-23 18:43:01 +01:00

chore: remove webkit and mobile safari from playwright (#10103)

Sign in to join this conversation.

Reviewers

No reviewers

viceice

mfenniak

0ko

fnetX

Labels

Clear labels   

arch

riscv64

Archived

  

backport/v1.19

Scheduled for backport to Forgejo v1.19

Archived

  

backport/v1.20

Scheduled for backport to Forgejo v1.20

Archived

  

backport/v1.21/forgejo

Scheduled for backport to Forgejo v1.21

Archived

  

backport/v10.0/forgejo

Automated backport to v10.0

Archived

  

backport/v11.0/forgejo

Automated backport to v11.0

  

backport/v12.0/forgejo

Automated backport to v12.0

Archived

  

backport/v13.0/forgejo

Automated backport to v13.0

Archived

  

backport/v14.0/forgejo

Automated backport to v14.0

  

backport/v7.0/forgejo

Scheduled for backport to Forgejo v7.0

Archived

  

backport/v8.0/forgejo

Scheduled for backport to Forgejo v8.0

Archived

  

backport/v9.0/forgejo

Scheduled for backport to Forgejo v9.0

Archived

  

breaking

The release containing this change is not backward compatible

  

bug

Something is not working

Archived

  

bug

confirmed

it can be reproduced

  

bug

duplicate

bug has already been reported in the Forgejo tracker

  

bug

needs-more-info

the information provided does not contain enough details

  

bug

new-report

bug has just been reported and need triage (default label on issue creation)

  

bug

reported-upstream

bug cannot be fixed within Forgejo easily, it has been reported upstream

  

code/actions

Forgejo Actions feature

  

code/api

API

  

code/auth

Forgejo Authentication

  

code/auth/faidp

Forgejo as Identity Provider (in OAuth/OIDC flow)

  

code/auth/farp

Forgejo as Relying Party / Client (in OAuth/OIDC flow)

  

code/email

Everything related to email in Forgejo

  

code/federation

Federation

  

code/git

Related to the Git backend in Forgejo

  

code/migrations

Migration between Git forges (i.e. for GitHub, GitLab, Gitea, Forgejo, etc.). NOT for database migrations.

  

code/packages

Forgejo package and container registry

  

code/wiki

  

database

MySQL

https://www.mysql.com/

  

database

PostgreSQL

https://www.postgresql.org/

  

database

SQLite

https://sqlite.org/

  

dependency-upgrade

https://codeberg.org/forgejo/forgejo/issues/2779

  

dependency

certmagic

github.com/caddyserver/certmagic

Archived

  

dependency

chart.js

https://github.com/chartjs/Chart.js

Archived

  

dependency

Chi

https://github.com/go-chi/chi/

Archived

  

dependency

Chroma

https://github.com/alecthomas/chroma/

Archived

  

dependency

citation.js

https://github.com/larsgw/citation.js/

Archived

  

dependency

codespell

https://github.com/codespell-project/codespell

Archived

  

dependency

css-loader

https://github.com/webpack-contrib/css-loader

Archived

  

dependency

devcontainers

https://github.com/devcontainers/cli

Archived

  

dependency

dropzone

https://github.com/dropzone/dropzone

Archived

  

dependency

editorconfig-checker

https://github.com/editorconfig-checker/editorconfig-checker

Archived

  

dependency

elasticsearch

https://www.elastic.co/elasticsearch

Archived

  

dependency

enmime

https://github.com/jhillyerd/enmime

Archived

  

dependency

F3

https://f3.forgefriends.org/

  

dependency

ForgeFed

https://forgefed.org

  

dependency

garage

https://git.deuxfleurs.fr/Deuxfleurs/garage

  

dependency

Git

https://git-scm.com/

Archived

  

dependency

git-backporting

https://github.com/kiegroup/git-backporting

Archived

  

dependency

Gitea

https://github.com/go-gitea/gitea

  

dependency

gitignore

https://github.com/github/gitignore

Archived

  

dependency

go-ap

https://github.com/go-ap/activitypub

Archived

  

dependency

go-enry

https://github.com/go-enry/go-enry

Archived

  

dependency

go-gitlab

https://github.com/xanzy/go-gitlab

Archived

  

dependency

Go-org

https://github.com/niklasfasching/go-org

Archived

  

dependency

go-rpmutils

https://github.com/sassoftware/go-rpmutils

Archived

  

dependency

go-sql-driver mysql

https://github.com/go-sql-driver/mysql/

Archived

  

dependency

go-swagger

github.com/go-swagger/go-swagger

Archived

  

dependency

go-version

https://github.com/hashicorp/go-version

Archived

  

dependency

go-webauthn

https://github.com/go-webauthn/webauthn

Archived

  

dependency

gocron

https://github.com/go-co-op/gocron

Archived

  

dependency

Golang

https://go.dev/

  

dependency

goldmark

https://github.com/yuin/goldmark

Archived

  

dependency

goquery

github.com/PuerkitoBio/goquery

Archived

  

dependency

Goth

https://github.com/markbates/goth/

Archived

  

dependency

grpc-go

https://github.com/grpc/grpc-go

Archived

  

dependency

happy-dom

https://github.com/capricorn86/happy-dom

Archived

  

dependency

Helm

https://helm.sh/

Archived

  

dependency

image-spec

https://github.com/opencontainers/image-spec

Archived

  

dependency

jsonschema

https://github.com/santhosh-tekuri/jsonschema

Archived

  

dependency

KaTeX

https://github.com/KaTeX/KaTeX

Archived

  

dependency

lint

All linting tools and libraries

Archived

  

dependency

MariaDB

https://mariadb.com/

Archived

  

dependency

Mermaid

https://github.com/mermaid-js/mermaid/

Archived

  

dependency

minio-go

https://github.com/minio/minio-go/

Archived

  

dependency

misspell

github.com/golangci/misspell/cmd/misspell

Archived

  

dependency

Monaco

https://github.com/microsoft/monaco-editor

Archived

  

dependency

PDFobject

https://pdfobject.com/

Archived

  

dependency

playwright

https://playwright.dev/

Archived

  

dependency

postcss

https://github.com/postcss/postcss

Archived

  

dependency

postcss-plugins

https://github.com/csstools/postcss-plugins

Archived

  

dependency

pprof

https://github.com/google/pprof

Archived

  

dependency

prometheus client_golang

https://github.com/prometheus/client_golang

Archived

  

dependency

protobuf

https://google.golang.org/protobuf

Archived

  

dependency

relative-time-element

https://github.com/github/relative-time-element

Archived

  

dependency

renovate

https://github.com/renovatebot/renovate

Archived

  

dependency

reply

https://code.forgejo.org/forgejo/reply

Archived

  

dependency

ssh

https://github.com/gliderlabs/ssh

Archived

  

dependency

swagger-ui

https://github.com/swagger-api/swagger-ui

Archived

  

dependency

tailwind

https://tailwindcss.com/

Archived

  

dependency

temporal-polyfill

https://github.com/fullcalendar/temporal-polyfill

Archived

  

dependency

terminal-to-html

github.com/buildkite/terminal-to-html

Archived

  

dependency

tests-only

Undifferentiated dependencies used for testing only

Archived

  

dependency

text-expander-element

https://github.com/github/text-expander-element

Archived

  

dependency

urfave

https://github.com/urfave/cli

Archived

  

dependency

vfsgen

https://github.com/lunny/vfsgen

Archived

  

dependency

vite

https://vitejs.dev/

Archived

  

dependency

Woodpecker CI

https://woodpecker-ci.org/

Archived

  

dependency

x tools

https://golang.org/x/tools

Archived

  

dependency

XORM

https://gitea.com/xorm/xorm

Archived

  

Discussion

  

duplicate

This issue or pull request already exists

  

enhancement/feature

New feature

  

forgejo/accessibility

Accessibility (a11y)

  

forgejo/branding

Branding (logo, name, tagline etc.)

  

forgejo/ci

Forgejo Actions CI configuration

  

forgejo/commit-graph

The commit graph feature and page.

  

forgejo/documentation

  

forgejo/furnace cleanup

Keeping Forgejo in sync with its dependencies and contributing back to them

Archived

  

forgejo/i18n

t9n/translation, l10n/localization, and i18n/internationalization of Forgejo

  

forgejo/interop

Interoperability with other services: Webhooks, bridges, integrations

  

forgejo/moderation

Moderation

  

forgejo/privacy

Privacy first

  

forgejo/release

Release management

  

forgejo/scaling

Performance and scaling

  

forgejo/security

Security (please disclose responsibly)

  

forgejo/ui

User interface

  

Gain

High

User research provides indicators that this would be good to have, interested contributors are encouraged to pick this.

  

Gain

Nice to have

This is likely worth having, but the assumption is not backed by user research data (it might benefit a small amount of users only.) Unlikely to receive much attention, but feel free to pick.

  

Gain

Undefined

Not enough information to assess the request's benefits. This issue may be closed if no gain is established: You can help by giving us more input.

  

Gain

Very High

User research indicates that this is an important improvement for Forgejo users. Contributions very welcome!

  

good first issue

Optimal for first-timers! Make sure to look for further explanations and ask for help if needed. If you want, you can consider the person who added this label as a point of contact.

  

i18n/backport-stable

This PR needs to be backported to stable branch of Forgejo safely and manually, using a migration script.

  

impact

large

Large impact: Potential data loss, many users affected, major degradation in UX.

  

impact

medium

Medium impact: Several users affected, degradation in UX, workarounds might be available but inconvenient.

  

impact

small

Small impact: No data loss, workarounds might be available, affects few users.

  

impact

unknown

Report was not yet triaged to assess impact.

  

Incompatible license

This pull request contains changes that are not (yet) compatible with the current Forgejo license

  

issue

closed

The issue was resolved in the repository of the dependency

  

issue

do-not-exist-yet

An issue should be created in the respository of the dependency

  

issue

open

An open issue exists in the upstream repository of the dependency

  

manual test

Pull requests that have been merged with a manual test

Archived

  

Manually tested during feature freeze

The manual test instructions were followed

  

OS

FreeBSD

Specific to the FreeBSD Operating System

  

OS

Linux

Specific to (GNU/)Linux Operating Systems

  

OS

macOS

Specific to the MacOS Operating System

  

OS

Windows

Specific to the Windows Operating System

  

problem

A user report about a problem. Needs to be triaged to find potential solutions.

  

QA

  

regression

found in the version of the milestone and not before

  

release blocker

Issues that must be fixed before the release can be published

  

Release Cycle

Feature Freeze

Only bug fixes with automated tests (except for CSS/JavaScript)

  

release-blocker

v7.0

Issues that must be fixed before Forgejo v7.0 can be released 17 April 2024

Archived

  

release-blocker

v7.0.1

Issues that must be fixed before Forgejo v7.0.1 can be released

Archived

  

release-blocker

v7.0.2

Issues that must be fixed before Forgejo v7.0.2 can be released

Archived

  

release-blocker

v7.0.3

Issues that must be fixed before Forgejo v7.0.3 can be released

Archived

  

release-blocker

v7.0.4

Issues that must be fixed before Forgejo v7.0.4 can be released

Archived

  

release-blocker

v8.0.0

Issues that must be fixed before Forgejo v8.0.0 can be released

Archived

  

release-blocker/v9.0.0

Issues that must be fixed before Forgejo v9.0.0 can be released

Archived

  

run-all-playwright-tests

Add this label to a PR to run all playwright tests manually.

  

run-end-to-end-tests

Trigger additional tests on the PR when it is ready to be merged

  

test

manual

manual testing has been documented

  

test

needed

test should be added

  

test

needs-help

help needed to add a test

  

test

not-needed

no additional test is needed

  

test

present

test has been added

  

untested

Pull requests that have been merged with no test and submitted as is to the dependency where they belong

Archived

  

User research - time-tracker

Time tracking feature for issues and the JS stopwatch.

  

valuable code

This PR was closed because the implementation is incomplete

  

worth a release-note

Add this PR to the release notes

  

User research - Accessibility

Requires input about accessibility features, likely involves user testing.

  

User research - Blocked

Do not pick as-is! We are happy if you can help, but please coordinate with ongoing redesign in this area.

  

User research - Community

Community features, such as discovering other people's work or otherwise feeling welcome on a Forgejo instance.

  

User research - Config (instance)

Instance-wide configuration, authentication and other admin-only needs.

  

User research - Errors

How to deal with errors in the application and write helpful error messages.

  

User research - Filters

How filter and search is being worked with.

  

User research - Future backlog

The issue might be inspiring for future design work.

  

User research - Git workflow

AGit, fork-based and new Git workflow, PR creation etc

  

User research - Labels

Active research about Labels

  

User research - Moderation

Moderation Featuers for Admins are undergoing active User Research

  

User research - Needs input

Use this label to let the User Research team know their input is requested.

  

User research - Notifications/Dashboard

Research on how users should know what to do next.

  

User research - Rendering

Text rendering, markup languages etc

  

User research - Repo creation

Active research about the New Repo dialog.

  

User research - Repo units

The repo sections, disabling them and the "Add more" button.

  

User research - Security

  

User research - Settings (in-app)

How to structure in-app settings in the future?

No labels

arch

riscv64

backport/v1.19

backport/v1.20

backport/v1.21/forgejo

backport/v10.0/forgejo

backport/v11.0/forgejo

backport/v12.0/forgejo

backport/v13.0/forgejo

backport/v14.0/forgejo

backport/v7.0/forgejo

backport/v8.0/forgejo

backport/v9.0/forgejo

breaking

bug

bug

confirmed

bug

duplicate

bug

needs-more-info

bug

new-report

bug

reported-upstream

code/actions

code/api

code/auth

code/auth/faidp

code/auth/farp

code/email

code/federation

code/git

code/migrations

code/packages

code/wiki

database

MySQL

database

PostgreSQL

database

SQLite

dependency-upgrade

dependency

certmagic

dependency

chart.js

dependency

Chi

dependency

Chroma

dependency

citation.js

dependency

codespell

dependency

css-loader

dependency

devcontainers

dependency

dropzone

dependency

editorconfig-checker

dependency

elasticsearch

dependency

enmime

dependency

F3

dependency

ForgeFed

dependency

garage

dependency

Git

dependency

git-backporting

dependency

Gitea

dependency

gitignore

dependency

go-ap

dependency

go-enry

dependency

go-gitlab

dependency

Go-org

dependency

go-rpmutils

dependency

go-sql-driver mysql

dependency

go-swagger

dependency

go-version

dependency

go-webauthn

dependency

gocron

dependency

Golang

dependency

goldmark

dependency

goquery

dependency

Goth

dependency

grpc-go

dependency

happy-dom

dependency

Helm

dependency

image-spec

dependency

jsonschema

dependency

KaTeX

dependency

lint

dependency

MariaDB

dependency

Mermaid

dependency

minio-go

dependency

misspell

dependency

Monaco

dependency

PDFobject

dependency

playwright

dependency

postcss

dependency

postcss-plugins

dependency

pprof

dependency

prometheus client_golang

dependency

protobuf

dependency

relative-time-element

dependency

renovate

dependency

reply

dependency

ssh

dependency

swagger-ui

dependency

tailwind

dependency

temporal-polyfill

dependency

terminal-to-html

dependency

tests-only

dependency

text-expander-element

dependency

urfave

dependency

vfsgen

dependency

vite

dependency

Woodpecker CI

dependency

x tools

dependency

XORM

Discussion

duplicate

enhancement/feature

forgejo/accessibility

forgejo/branding

forgejo/ci

forgejo/commit-graph

forgejo/documentation

forgejo/furnace cleanup

forgejo/i18n

forgejo/interop

forgejo/moderation

forgejo/privacy

forgejo/release

forgejo/scaling

forgejo/security

forgejo/ui

Gain

High

Gain

Nice to have

Gain

Undefined

Gain

Very High

good first issue

i18n/backport-stable

impact

large

impact

medium

impact

small

impact

unknown

Incompatible license

issue

closed

issue

do-not-exist-yet

issue

open

manual test

Manually tested during feature freeze

OS

FreeBSD

OS

Linux

OS

macOS

OS

Windows

problem

QA

regression

release blocker

Release Cycle

Feature Freeze

release-blocker

v7.0

release-blocker

v7.0.1

release-blocker

v7.0.2

release-blocker

v7.0.3

release-blocker

v7.0.4

release-blocker

v8.0.0

release-blocker/v9.0.0

run-all-playwright-tests

run-end-to-end-tests

test

manual

test

needed

test

needs-help

test

not-needed

test

present

untested

User research - time-tracker

valuable code

worth a release-note

User research - Accessibility

User research - Blocked

User research - Community

User research - Config (instance)

User research - Errors

User research - Filters

User research - Future backlog

User research - Git workflow

User research - Labels

User research - Moderation

User research - Needs input

User research - Notifications/Dashboard

User research - Rendering

User research - Repo creation

User research - Repo units

User research - Security

User research - Settings (in-app)

Milestone

Clear milestone

No items

No milestone

Forgejo v14.0.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

5 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/forgejo!10103

No description provided.